fix: render text under block cursor with cursorAccent color#131
Merged
Conversation
Block cursors now re-draw the character underneath using the cursorAccent theme color, making text visible on the opaque cursor. Uses ctx.clip() to prevent wide characters from bleeding outside the cursor cell. Co-authored-by: Nathan Cooper <ncoop57@users.noreply.github.com>
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
sreya
added a commit
to 0xBigBoss/ghostty-web
that referenced
this pull request
Feb 24, 2026
Block cursors now re-draw the character underneath using the cursorAccent theme color, making text visible on the opaque cursor. Uses ctx.clip() to prevent wide characters from bleeding outside the cursor cell. Co-authored-by: Nathan Cooper <ncoop57@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block cursors now re-draw the character underneath using the cursorAccent theme color, making text visible on the opaque cursor. Uses ctx.clip() to prevent wide characters from bleeding outside the cursor cell.